Skip to content

chore: Replace serde_yaml with yaml_serde - #1097

Merged
xeniape merged 3 commits into
mainfrom
chore/replace-serde-yaml
Oct 14, 2026
Merged

chore: Replace serde_yaml with yaml_serde#1097
xeniape merged 3 commits into
mainfrom
chore/replace-serde-yaml

Conversation

@xeniape

@xeniape xeniape commented Oct 14, 2026

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#898

Integrationtests

--- PASS: kuttl (614.30s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cluster-operation_zookeeper-latest-3.9.6_openshift-false (72.37s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.6_use-server-tls-true_use-client-auth-tls-false_openshift-false (120.63s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.6_use-server-tls-false_use-client-auth-tls-true_openshift-false (101.92s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.6_use-server-tls-false_use-client-auth-tls-false_openshift-false (79.15s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.5_use-server-tls-true_use-client-auth-tls-true_openshift-false (105.47s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.5_use-server-tls-true_use-client-auth-tls-false_openshift-false (88.26s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.5_use-server-tls-false_use-client-auth-tls-false_openshift-false (72.99s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.5_use-server-tls-false_use-client-auth-tls-true_openshift-false (94.79s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.5_openshift-false (54.30s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.6_openshift-false (87.89s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.6_openshift-false (68.37s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.5_openshift-false (70.27s)
        --- PASS: kuttl/harness/znode_zookeeper-latest-3.9.6_openshift-false (28.95s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.6_use-server-tls-true_use-client-auth-tls-true_openshift-false (95.10s)
PASS

Unittests

test result: ok. 62 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 14, 2026
@xeniape
xeniape marked this pull request as ready for review October 14, 2026 10:42
@xeniape xeniape mentioned this pull request Oct 14, 2026
Open
19 tasks done
sbernauer
sbernauer previously approved these changes Oct 14, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread Cargo.toml Outdated
Comment thread CHANGELOG.md
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 14, 2026
@xeniape
xeniape requested a review from sbernauer October 14, 2026 11:38
@xeniape
xeniape added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit fb30c4c Oct 14, 2026
13 checks passed
@xeniape
xeniape deleted the chore/replace-serde-yaml branch October 14, 2026 11:53
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 14, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@xeniape xeniape

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xeniape @sbernauer @lfrancke